-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/0.3.2 #422
Merged
Merged
Dev/0.3.2 #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bursts and variants as well as tilted runs.
…ased number of Gingles' districts; add further documentation SingleMetricOptimizer class methods; delint optimization.py
…partitions and to store rolling best partition/score as instance variables.
…xpose `best_part`, `best_score`, and `score` as readonly properties. Add stubs for new cycling beta functions.
Thank you all for your work on this! We will be adding this in version 0.3.2.
…for local storage
cdonnay
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Peter! I think I only have spelling/doc strings comments.
cdonnay
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main PR for release 0.3.2.
Main Changes
SingleMetricOptimizer
andGingleator
classes so that we can run short-burst, simulated annealing, and tilted runsfind_balance_edge_cuts_memoization
andfind_balance_edge_cuts_contration
work. Now you must specify if you are intending to cut off a single epsilon-balanced district via a one-sided-cut or if you intend to split into two epsilon-balanced districts.gerrychain.tree.recursive_tree_part
andgerrychain.tree.recursive_seed_part_inner
functions.epsilon_tree_bipartition
function that deals with the case where we would like to split a subgraph into two epsilon-balanced districts.